perf(semantic): reduce cloning CompactStrs when declaring references#4239
Closed
overlookmotel wants to merge 2 commits intomainfrom
Closed
perf(semantic): reduce cloning CompactStrs when declaring references#4239overlookmotel wants to merge 2 commits intomainfrom
CompactStrs when declaring references#4239overlookmotel wants to merge 2 commits intomainfrom
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on |
CodSpeed Performance ReportMerging #4239 will degrade performances by 3.2%Comparing Summary
Benchmarks breakdown
|
Member
Author
|
Od dear. That didn't work. |
Boshen
deleted the
07-12-perf_semantic_reduce_cloning_compactstr_s_when_declaring_references
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hash map
EntryAPI requires an owned key. Avoid using it so don't have to clone the reference nameCompactStrunless the hashmap need an insertion.Using
Atominstead ofCompactStras hash map key (#3972) would be a better long-term solution, but that's not possible currently.